Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Exceptions Handled by Retry Middleware Configurable #2701

Closed
tad3j opened this issue Apr 5, 2017 · 3 comments · Fixed by #5929
Closed

Make Exceptions Handled by Retry Middleware Configurable #2701

tad3j opened this issue Apr 5, 2017 · 3 comments · Fixed by #5929

Comments

@tad3j
Copy link

tad3j commented Apr 5, 2017

I was having troubles finding which exceptions are handled by Retry Middleware, so I asked on freenode scrapy irc channel (should obviously check the source code). Paul from scrapinhub helped me there and pointed me to the source code.

Beside that he also asked me to open an issue here.
He gave a great suggestion to make exceptions handled by RetryMiddleware configurable, so if we don't like defaults we can configure our own.

Beside that he said that the handled exceptions in question are not documented well; I'm just mentioning it here, didn't want to open another issue (I guess by adding them to settings will also require some documentation).

@sanjucta
Copy link

Hi,
Since this is tagged as an as 'help-wanted' and 'enhancement', I think the help wanted here is to make the exceptions handled configurable. I'd like to work on this.
I think the way the exceptions should be made configurable is to allow the user to exclude certain exceptions rather than add exceptions, since we only want to re-try in the case of exceptions in which the issue could have been resolved when we retry . Does that sound reasonable?

@doprdele
Copy link

^^ would also like to see this. how exactly should we retry on exceptions now?

@serhii73
Copy link
Collaborator

I'm on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants