Import Request in the Template file

[zhongdai]

I have been creating many spiders recently, and I noticed I had to add below line every time

from scrapy.http import Request

I think for most cases we need the Request to crawl to other pages, only for very simple spider we don't need that. Is it possible to include that line to the template?

[kmike]

The intention is for users to use scrapy.Request, import scrapy is already in the template. Does it work for you?

[zhongdai]

Thanks for the quick the response. I didn't noticed Request has been declared on the top level, I checked the API document and always use it from scrapy.http.

That is fair enough, and please close this issue.

[kmike]

Yeah, it'd be nice to mention the shortcut in API docs for Request object: https://doc.scrapy.org/en/latest/topics/request-response.html.

[keremgocen]

I'd like to grab this if that's ok

[marlenachatzigrigoriou]

Hello! Is this issue still open? Does @keremgocen carry this? If not, could you give me some guidance on what needs to be done (as it was reopened) in order to contribute?

[Gallaecio]

This is still open indeed, and it seems like there has been no attempt to address it after #2757, which seems abandoned.

[marlenachatzigrigoriou]

Great. Could you give me more guidance on what I should do? I saw your comment #2757 (comment) and I assume that I have to begin from this point.

[Gallaecio]

Yes.

It’s relatively hard to find what I mention in this comment, but referencing all import paths looks like this:

.. class:: scrapy.http.request.Request
.. class:: scrapy.http.Request
.. class:: scrapy.Request(…)

Then there are some possible additional changes to make, but it’s up to you whether to make them or not, since they are not covered by this issue report:

• The same could be done for other classes that have a top-level import in https://github.com/scrapy/scrapy/blob/master/scrapy/__init__.py
• In addition to covering all import paths in the reference documentation, you could search the documentation (and even the docstrings in code) for references to the longer import paths, and switch those usages to the short import path, as the shortest import path should probably be the recommendation in the documentation.