Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[idea] Supporting also `link` tags in `Response.follow` #2785

Closed
starrify opened this issue Jun 13, 2017 · 2 comments
Closed

[idea] Supporting also `link` tags in `Response.follow` #2785

starrify opened this issue Jun 13, 2017 · 2 comments

Comments

@starrify
Copy link
Contributor

@starrify starrify commented Jun 13, 2017

Currently the Response.follow method supports Selector objects whose root tag are <a>. It'll be nice to support also link tags.

Related code: here

Sample code:

# Now
for href in response.css('link[rel=next]::attr(href)').extract():
    yield response.follow(href)

# When the proposed feature is available
for link_sel in response.css('link[rel=next]'):
    yield response.follow(link_sel)
@kmike
Copy link
Member

@kmike kmike commented Jun 13, 2017

I'm fine with such addition.

@dangra
Copy link
Member

@dangra dangra commented Jul 24, 2017

implemented in #2789

@dangra dangra closed this Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants