Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit message for NotImplementedError when parse callback not defined #2831

Closed
redapple opened this issue Jul 17, 2017 · 2 comments
Closed

Explicit message for NotImplementedError when parse callback not defined #2831

redapple opened this issue Jul 17, 2017 · 2 comments
Labels

Comments

@redapple
Copy link
Contributor

@redapple redapple commented Jul 17, 2017

Motivation: https://stackoverflow.com/questions/45113478/scrapy-request-returns-notimplementederror

Proposal: add an explicit message saying what's missing in the spider class definition.
Although obvious for experienced Scrapy users, NotImplementedError for missing parse can be obscure for newcomers.
Also, NotImplementedError is not mentioned in the docs for this situation.

@kirankoduru
Copy link
Contributor

@kirankoduru kirankoduru commented Jul 30, 2017

I created a PR #2865 with the intended message. I wished to update the docs but I am trying to grasp where would be a better place to have this.

@redapple
Copy link
Contributor Author

@redapple redapple commented Aug 9, 2017

Fixed via #2865

@redapple redapple closed this Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.