Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit message for NotImplementedError when parse callback not defined #2831

redapple opened this issue Jul 17, 2017 · 2 comments


Copy link


Proposal: add an explicit message saying what's missing in the spider class definition.
Although obvious for experienced Scrapy users, NotImplementedError for missing parse can be obscure for newcomers.
Also, NotImplementedError is not mentioned in the docs for this situation.

Copy link

eventuallyc0nsistent commented Jul 30, 2017

I created a PR #2865 with the intended message. I wished to update the docs but I am trying to grasp where would be a better place to have this.

Copy link
Contributor Author

redapple commented Aug 9, 2017

Fixed via #2865

@redapple redapple closed this as completed Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

No branches or pull requests

2 participants