Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect 308 missing #2844

Closed
maugch opened this issue Jul 22, 2017 · 2 comments
Closed

Redirect 308 missing #2844

maugch opened this issue Jul 22, 2017 · 2 comments
Labels

Comments

@maugch
Copy link

@maugch maugch commented Jul 22, 2017

I did a check on the RedirectMiddleware and noticed that code 308 is missing. Is there a reason for that?
Some websites don't update their sitemap and have a long list of 308 from http to https.

(side note: is there a way to add "s" before a link is scraped?)

@redapple
Copy link
Contributor

@redapple redapple commented Jul 24, 2017

Hi @maugch , I don't see any specific reason for that omission, except maybe that the RFC for HTTP 308 is rather "new" (2015) and no-one added the code to the middleware.

If would be good that handle 308 indeed.

@redapple redapple added bug http labels Jul 24, 2017
@redapple
Copy link
Contributor

@redapple redapple commented Jul 24, 2017

Interestingly enough, HTTP 308 is tested in HTTP cache extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants