Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeprecationWarning: inspect.getargspec() #2862

Closed
andreip opened this issue Jul 28, 2017 · 1 comment
Closed

DeprecationWarning: inspect.getargspec() #2862

andreip opened this issue Jul 28, 2017 · 1 comment
Milestone

Comments

@andreip
Copy link
Contributor

@andreip andreip commented Jul 28, 2017

Hi,

I've tried searching for a similar problem but couldn't find a discussion in scrapy about it, so starting one.

build  │   func_args, _, _, _ = inspect.getargspec(func)
build  │ /usr/local/lib/python3.6/site-packages/scrapy/utils/python.py:201: DeprecationWarning: inspect.getargspec() is deprecated, use inspect.signature() or inspect.getfullargspec()

We've stumbled into this log a LOT, actually getting spammed by it currently when we execute some twisted.trial.unittest tests where each unittest spins up a CrawlerRunner for our live tests that do exactly what unittests do but with live data fetching.

Could we leave the current behavior for py2 but port the getargspec to getfullargspec as is suggested in the warning? I see latter for py3 includes additional return values, but should be a quick port. Would you be ok with a patch? Thanks

@kmike
Copy link
Member

@kmike kmike commented Jul 28, 2017

Sure, it would be a good addition!

@redapple redapple added this to the v1.4.1 milestone Jul 31, 2017
@dangra dangra closed this in #2864 Aug 1, 2017
dangra added a commit that referenced this issue Aug 1, 2017
#2864)

Use getfullargspec under the scenes for py3 to stop DeprecationWarning. 

Closes #2862
@kmike kmike modified the milestones: v1.4.1, v1.5 Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants