Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about the signal retry_complete #3069

Closed
lifei1245 opened this issue Jan 11, 2018 · 2 comments
Closed

about the signal retry_complete #3069

lifei1245 opened this issue Jan 11, 2018 · 2 comments

Comments

@lifei1245
Copy link

@lifei1245 lifei1245 commented Jan 11, 2018

I didn't find the singnal in the singnal list,how can I use it

@cathalgarvey
Copy link
Contributor

@cathalgarvey cathalgarvey commented Feb 20, 2018

Searching for the signal, I only found a mention of it in the docstrings for middleware, but it appears nowhere in the code. On a local copy of the Scrapy git project, I ran:

$ git rev-list --all | xargs git grep retry_complete | grep -v 'so other extensions'

..and got nothing. The signal seems to be mentioned only in the docstrings, and it predates the migration to Git. It may be a case of outdated docs?

@silviaclaire
Copy link

@silviaclaire silviaclaire commented Mar 8, 2019

Pull request #3668 needs to be merged. Docstrings still talks about the unexisting signal.

@kmike kmike closed this in #3668 Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants