Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

root logger's level is always set to NOTSET #3146

Closed
joelkim opened this issue Feb 27, 2018 · 1 comment · Fixed by #3960
Closed

root logger's level is always set to NOTSET #3146

joelkim opened this issue Feb 27, 2018 · 1 comment · Fixed by #3960
Labels
logging

Comments

@joelkim
Copy link

@joelkim joelkim commented Feb 27, 2018

Currently, the log level of a root logger is always automatically re-set to NOTSET level in install_scrapy_root_handler function call if I add handlers to root logger:

scrapy/scrapy/utils/log.py

Line 110 in 108f8c4

logging.root.setLevel(logging.NOTSET)

Can anybody explain why this level reset is required?
This issue is relevant to issue #2352, #2149, I think.
@thernstig thernstig mentioned this issue Mar 10, 2018
Closed
@thernstig
Copy link
Contributor

@thernstig thernstig commented Mar 10, 2018

@joelkim please see my answer in #2149. I believe this issue can be closed as a clone of that.

@thernstig thernstig mentioned this issue Mar 11, 2018
Closed
@joelkim joelkim closed this as completed Nov 5, 2018
@thernstig thernstig mentioned this issue Aug 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
logging
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update documentation for logging manually
3 participants
@joelkim @cathalgarvey @thernstig