Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File descriptor leak in FeedExporter #3391

Closed
dangra opened this issue Aug 15, 2018 · 1 comment · Fixed by #4023
Closed

File descriptor leak in FeedExporter #3391

dangra opened this issue Aug 15, 2018 · 1 comment · Fixed by #4023

Comments

@dangra
Copy link
Member

@dangra dangra commented Aug 15, 2018

Test suite under windows fails to remove a file at https://github.com/scrapy/scrapy/pull/3315/files#diff-0f004a6e06393cc5e29012b83956eed2L245 because FeedExporter instances keeps an open file descriptor created for the test case.

We need to find the leak and close the file descriptor properly on close_spider signal.

@Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Sep 17, 2019

@dangra Seeing as tests are passing on Windows, should we close this?

Oh, you probably want to be able to remove ignore_errors=True from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants