Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name parameters uniformly (Cache Policy API) #3734

Closed
anubhavp28 opened this issue Apr 9, 2019 · 1 comment
Closed

Name parameters uniformly (Cache Policy API) #3734

anubhavp28 opened this issue Apr 9, 2019 · 1 comment

Comments

@anubhavp28
Copy link
Contributor

@anubhavp28 anubhavp28 commented Apr 9, 2019

def is_cached_response_fresh(self, response, request):

It will look better if we name the second parameter as cachedresponse (in place of just response).

In fact, implementation of policy for RFC2616 compliant HTTP cache names it correctly.

def is_cached_response_fresh(self, cachedresponse, request):

I am sending a pull request for the same.

@Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Apr 11, 2019

@anubhavp28 I don’t think it is necessary for you to open an issue for something when you plan to send a pull request right away. Feel free to open your pull requests directly without opening an issue first 🙂

@kmike kmike closed this in #3735 Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants