Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items as Dataclasses #3761

Closed
mredaelli opened this issue May 2, 2019 · 4 comments · Fixed by #3881
Closed

Items as Dataclasses #3761

mredaelli opened this issue May 2, 2019 · 4 comments · Fixed by #3881

Comments

@mredaelli
Copy link

mredaelli commented May 2, 2019

Is there any plan to support dataclasses as yield-able results from crawlers (and possibly meta in Request/Result)?

It would be a very welcome addition for us, mostly for typing reasons, IDE completion, additional logic.
And it should also be simple to implement (just call dataclasses.asdict())?

@gsb-eng
Copy link

gsb-eng commented May 13, 2019

@Gallaecio I would like to implement this, any discussion required before proceeding further?

@Gallaecio
Copy link
Member

Gallaecio commented May 13, 2019

@gsb-eng I think you can go ahead.

@kmike
Copy link
Member

kmike commented Jun 25, 2019

+1 to add dataclasses and attrs support (in separate pull requests), I think it'd be awesome to have support for them.

@kmike
Copy link
Member

kmike commented Jun 25, 2019

#2807 is related, though not the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants