Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOWNLOAD_MAXSIZE logger level shouldn't be Error #3874

Closed
mohmad-null opened this issue Jul 13, 2019 · 8 comments · Fixed by #4752
Closed

DOWNLOAD_MAXSIZE logger level shouldn't be Error #3874

mohmad-null opened this issue Jul 13, 2019 · 8 comments · Fixed by #4752

Comments

@mohmad-null
Copy link

When triggered, the DOWNLOAD_MAXSIZE setting raises an ERROR level logging event. I don't think it should be at this level. Error is "something went wrong"; I've explicitly told Scrapy I don't want files of this size, so it's not an error to not download them. WARN or even just INFO makes more sense.

I'm logging Error levels and above to stderr so I can keep track of them easily and it's being flooded by these. In fact, apart from a couple of genuine errors, of the ~100,000 requests my spider has made so far, these are the only Errors that are showing up.

@kmike
Copy link
Member

kmike commented Jul 16, 2019

Sounds good; pull requests are welcome.

@991rajat
Copy link

Is this Open?

@WinterComes
Copy link
Contributor

Could you take a look at my last PR please, I hope I get it right.
Sorry for a little mix-up with yesterday PRs. I was scared of a failed tests, haha

@chrisbangun
Copy link

Hi, newbie here and would love to learn and contribute. is this still open?

@Gallaecio
Copy link
Member

@chrisbangun There’s already an open proposal which seems good: #3886

@faizan2700
Copy link
Contributor

I want to contribute to this enhancement #3874 as I am beginner. I have been reading code of scrapy and located from where this error is being raised. Please assign this to me.

@Gallaecio
Copy link
Member

@faizan2700 There’s someone already working on it, with a working proposal ready: #3886

@sprzedwojski
Copy link

#3886 has been accepted and looks ready to be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants