-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Random(?) test_crawler.py failure on Travis #4014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
for some reason github search did not give me any result when I searched test_deprecated_attribute_spiders so I opened the other issue. hoping this comment gets indexed by github |
@s-sanjay That's ok, I only included the full path in the description after seeing your issue. Thanks! |
let me try to run in the same environment using the same HASHSEED |
the flakiness is happening due to this
These warnings |
Should we use https://pypi.org/project/flaky/ to have these tests re-run a few times if they fail? (discovered through scrapinghub/frontera#379) |
@Gallaecio so when tests fail due to some other issue re running them is great but shouldn't we as much as possible prevent flakiness from being introduced.. as a last resort we can re run them but if we re run would it not also delay fixing the reasons for flakiness ? |
Every now and then the Travis build fails on
tests.test_crawler.CrawlerRunnerTestCase.test_deprecated_attribute_spiders
, I'm not sure why.Some examples:
PS: Sorry, I feel bad for ignoring the bug report template, but I felt like it didn't apply in this case.
The text was updated successfully, but these errors were encountered: