Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Python 3.8 support official #4085

Closed
Gallaecio opened this issue Oct 21, 2019 · 12 comments · Fixed by #4092
Closed

Make Python 3.8 support official #4085

Gallaecio opened this issue Oct 21, 2019 · 12 comments · Fixed by #4092

Comments

@Gallaecio
Copy link
Member

This involves, among other things:

  • Enabling a Python 3.8 environment in Tox
  • Enabling a Python 3.8 job in the Travis CI
  • Updating the setup.py file
@Gallaecio Gallaecio changed the title Add Python 3.8 support to Scrapy Make Python 3.8 support official Oct 21, 2019
@wRAR
Copy link
Member

wRAR commented Oct 21, 2019

Does Travis already support it?

@wRAR
Copy link
Member

wRAR commented Oct 21, 2019

According to https://docs.travis-ci.com/user/languages/python/ it does

@illgitthat
Copy link
Contributor

I am trying to install scrapy for python 3.8 in a Windows environment. Are there currently any ways I can do this? Or is this blocked upstream by conda conda/conda#9343

@Gallaecio
Copy link
Member Author

I am trying to install scrapy for python 3.8 in a Windows environment. Are there currently any ways I can do this? Or is this blocked upstream by conda conda/conda#9343

You can try using pip. If you cannot get it to work with pip, then you’ll need to wait for Conda to support Python 3.8.

@further-reading
Copy link
Contributor

Hey! I'll grab this one if it is okay?

@illgitthat
Copy link
Contributor

I am trying to install scrapy for python 3.8 in a Windows environment. Are there currently any ways I can do this? Or is this blocked upstream by conda conda/conda#9343

You can try using pip. If you cannot get it to work with pip, then you’ll need to wait for Conda to support Python 3.8.

No luck using just pip install scrapy unfortunately.

@asciidiego
Copy link

Installing Python 3.8.0 and immediately later scrapy fails.

Here's the commands used:

pip install python=3.8.0
pip install scrapy

My workstation: 4.19.79-1-MANJARO GNU/Linux

The log itself: https://pastebin.com/cAawd2jB

@wRAR
Copy link
Member

wRAR commented Oct 28, 2019

@diegovincent this is not related to Scrapy, the log shows a problem with compiling lxml and other libraries.

@asciidiego
Copy link

@wRAR But why would that happen? is lxml not "ready" for 3.8? But after all, scrapy depends on the lxml library, so it might be a good idea to have it here?

@wRAR
Copy link
Member

wRAR commented Oct 28, 2019

@diegovincent your compiler toolchain seems broken, and no, this is not a good place to discuss problems with installing third-party modules.

@asciidiego
Copy link

I used Anaconda.

And ok, I won't discuss it anymore here, but FYI the error seems to persist even after conda officially supports 3.8.0.

@Gallaecio
Copy link
Member Author

I won't discuss it anymore here

Feel free to create a separate issue about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants