Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

constructor, initializer → __init__ method #4086

Closed
Gallaecio opened this issue Oct 21, 2019 · 1 comment · Fixed by #4088
Closed

constructor, initializer → __init__ method #4086

Gallaecio opened this issue Oct 21, 2019 · 1 comment · Fixed by #4088
Labels
docs enhancement good first issue

Comments

@Gallaecio
Copy link
Member

There are several places in the documentation and comments where we use the words ‘constructor’ or ‘initializer’ to refer to the __init__ method of a class. We should change the wording to explicitly say ‘__init__ method’ instead.

Related to #2354.
@ammarnajjar
Copy link
Contributor

I would like to give this a shot, if it's alright 😄

ammarnajjar added a commit to ammarnajjar/scrapy that referenced this issue Oct 21, 2019
@ammarnajjar
docs: use __init__ method instead of constructor
68a7d05 
Issue scrapy#4086
@ammarnajjar ammarnajjar mentioned this issue Oct 21, 2019
Merged
ammarnajjar added a commit to ammarnajjar/scrapy that referenced this issue Oct 21, 2019
@ammarnajjar
docs: always surround __init__ with `` in docs
9ef093a 
Issue scrapy#4086
ammarnajjar added a commit to ammarnajjar/scrapy that referenced this issue Oct 21, 2019
@ammarnajjar
docs: always surround __init__ with `` in docs
ecb6cfd 
Issue scrapy#4086
ammarnajjar added a commit to ammarnajjar/scrapy that referenced this issue Oct 21, 2019
@ammarnajjar
docs: always surround __init__ with `` in docs
da8cd94 
Issue scrapy#4086
ammarnajjar added a commit to ammarnajjar/scrapy that referenced this issue Oct 22, 2019
@ammarnajjar
docs: correct point,comma and plural replacements
5219435 
Issue scrapy#4086
ammarnajjar added a commit to ammarnajjar/scrapy that referenced this issue Oct 22, 2019
@ammarnajjar
docs: correct point,comma and plural replacements
d21e103 
Issue scrapy#4086
ammarnajjar added a commit to ammarnajjar/scrapy that referenced this issue Oct 22, 2019
@ammarnajjar
docs: use "constructor" for from_settings() & rom_crawler() factory m…
7a84a4b 
…ethods

Issue scrapy#4086
ammarnajjar added a commit to ammarnajjar/scrapy that referenced this issue Oct 22, 2019
@ammarnajjar @kmike
use instantiation for "Crawler"
7fba843 
Issue scrapy#4086

Co-Authored-By: Mikhail Korobov <kmike84@gmail.com>
ammarnajjar added a commit to ammarnajjar/scrapy that referenced this issue Oct 22, 2019
@ammarnajjar
docs: use "constructor" for "from_crawler"
bf5c1a3 
Issue scrapy#4086
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: use __init__ method instead of constructor ammarnajjar/scrapy
2 participants
@Gallaecio @ammarnajjar