Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constructor, initializer → __init__ method #4086

Closed
Gallaecio opened this issue Oct 21, 2019 · 1 comment · Fixed by #4088
Closed

constructor, initializer → __init__ method #4086

Gallaecio opened this issue Oct 21, 2019 · 1 comment · Fixed by #4088

Comments

@Gallaecio
Copy link
Member

Gallaecio commented Oct 21, 2019

There are several places in the documentation and comments where we use the words ‘constructor’ or ‘initializer’ to refer to the __init__ method of a class. We should change the wording to explicitly say ‘__init__ method’ instead.

Related to #2354.

@ammarnajjar
Copy link
Contributor

ammarnajjar commented Oct 21, 2019

I would like to give this a shot, if it's alright 😄

ammarnajjar added a commit to ammarnajjar/scrapy that referenced this issue Oct 21, 2019
ammarnajjar added a commit to ammarnajjar/scrapy that referenced this issue Oct 21, 2019
ammarnajjar added a commit to ammarnajjar/scrapy that referenced this issue Oct 21, 2019
ammarnajjar added a commit to ammarnajjar/scrapy that referenced this issue Oct 21, 2019
ammarnajjar added a commit to ammarnajjar/scrapy that referenced this issue Oct 22, 2019
ammarnajjar added a commit to ammarnajjar/scrapy that referenced this issue Oct 22, 2019
ammarnajjar added a commit to ammarnajjar/scrapy that referenced this issue Oct 22, 2019
ammarnajjar added a commit to ammarnajjar/scrapy that referenced this issue Oct 22, 2019
Issue scrapy#4086

Co-Authored-By: Mikhail Korobov <kmike84@gmail.com>
ammarnajjar added a commit to ammarnajjar/scrapy that referenced this issue Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants