Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong fact in JOBDIR documentation about requests needing to be pickle-serializable #4124

Closed
Gallaecio opened this issue Nov 4, 2019 · 0 comments · Fixed by #4139
Closed

Fix wrong fact in JOBDIR documentation about requests needing to be pickle-serializable #4124

Gallaecio opened this issue Nov 4, 2019 · 0 comments · Fixed by #4139
Labels
bug docs

Comments

@Gallaecio
Copy link
Member

Gallaecio commented Nov 4, 2019 •
edited
Loading

The documentation about using JODBIR says that requests need to be serializable with pickle.

But, thanks to feedback from @kmike, now I know that their callback and errback methods do not need to be pickle-serializable as long as they are spider methods.

The documentation should be clear about this.

Related to #4125.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve the details about request serialization requirements for JOBDIR Gallaecio/scrapy
1 participant
@Gallaecio