Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random failures in CrawlTestCase.test_fixed_delay #4268

Closed
wRAR opened this issue Jan 9, 2020 · 15 comments · Fixed by #4372
Closed

Random failures in CrawlTestCase.test_fixed_delay #4268

wRAR opened this issue Jan 9, 2020 · 15 comments · Fixed by #4372

Comments

@wRAR
Copy link
Contributor

@wRAR wRAR commented Jan 9, 2020

On some test runs CrawlTestCase.test_fixed_delay fails with

>       yield self._test_delay(total=3, delay=0.1)
E   twisted.trial.unittest.FailTest: twisted.trial.unittest.FailTest: True is not false : test total or delay values are too small
@joybh98
Copy link
Contributor

@joybh98 joybh98 commented Jan 10, 2020

Hey, can I work on this ?

@wRAR
Copy link
Contributor Author

@wRAR wRAR commented Jan 10, 2020

@joybhallaa sure!

@sudonitin
Copy link

@sudonitin sudonitin commented Feb 3, 2020

Hey, @joybhallaa you still working on it? If not @Gallaecio can I try it?

@joybh98
Copy link
Contributor

@joybh98 joybh98 commented Feb 3, 2020

@GlobeFire, sure !

@sakshamb2113
Copy link
Contributor

@sakshamb2113 sakshamb2113 commented Feb 19, 2020

@wRAR can i work on this issue ?

@wRAR
Copy link
Contributor Author

@wRAR wRAR commented Feb 19, 2020

@sakshamb2113 sure

@sakshamb2113
Copy link
Contributor

@sakshamb2113 sakshamb2113 commented Feb 22, 2020

@wRAR I looked at the PR you made recently where there is a similar error as you described above for pypy3 tox env . Does this error always come up for pypy3 only?

@wRAR
Copy link
Contributor Author

@wRAR wRAR commented Feb 22, 2020

@sakshamb2113 it's not similar at all.

@wRAR
Copy link
Contributor Author

@wRAR wRAR commented Feb 22, 2020

@sakshamb2113 or do you mean #4367? Even there a similar error also happened for the py38-asyncio env.

@sakshamb2113
Copy link
Contributor

@sakshamb2113 sakshamb2113 commented Feb 22, 2020

@wRAR I ran test_crawl.py a number of times on py3 and flake8 on local machine but was not able to reproduce this error even for total and delay variables both equal to zero. That should mean that this error arises only when tests run on travis ci and has something to do with the environment variables there.

@wRAR
Copy link
Contributor Author

@wRAR wRAR commented Feb 23, 2020

@sakshamb2113 I had this error locally.

@Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Feb 24, 2020

It should be a “simple” matter of increasing the parameters of the corresponding tests, using the minimum values that do not cause the tests to fail.

@sakshamb2113
Copy link
Contributor

@sakshamb2113 sakshamb2113 commented Feb 24, 2020

I was able to obtain the error locally after which I changed the "total" parameter from 3 to 4 and ran the tests.I have not obtained any error until now.

@sakshamb2113
Copy link
Contributor

@sakshamb2113 sakshamb2113 commented Feb 24, 2020

@Gallaecio @wRAR Should we change the "delay" parameter from 0.1 to 0.11 (I got no error for delay=0.11 in 80 test runs) ?

@Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Feb 25, 2020

@wRAR Can you check if that also works for you? If so, I guess it makes sense for @sakshamb2113 to create a pull request with the change, and we can see if the PyPy Travis CI job also works, and we can hope it will continue to work after we merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants