Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setting to choose a custom AsyncIO loop #4306

Closed
Gallaecio opened this issue Feb 6, 2020 · 1 comment · Fixed by #4414
Closed

Add a setting to choose a custom AsyncIO loop #4306

Gallaecio opened this issue Feb 6, 2020 · 1 comment · Fixed by #4414

Comments

@Gallaecio
Copy link
Member

Gallaecio commented Feb 6, 2020

Just as #4294 allows to easily choose a custom Twister reactor, I think we should consider implementing a setting that allows choosing a custom AsyncIO loop (when using an AsyncIO reactor).

I’m thinking of https://github.com/MagicStack/uvloop, which I’ve used in web development, and can’t help but wonder if it could improve Scrapy performance in some scenarios.

@sakshamb2113
Copy link
Contributor

sakshamb2113 commented Mar 2, 2020

@Gallaecio I am working on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants