Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SCRAPY_SELECTORS_BACKEND from scrapy.settings.deprecated #4376

Closed
Gallaecio opened this issue Feb 25, 2020 · 3 comments · Fixed by #4378
Closed

Remove SCRAPY_SELECTORS_BACKEND from scrapy.settings.deprecated #4376

Gallaecio opened this issue Feb 25, 2020 · 3 comments · Fixed by #4378

Comments

@Gallaecio
Copy link
Member

Gallaecio commented Feb 25, 2020

There is no trace of SCRAPY_SELECTORS_BACKEND in the code anymore, so that line should go.

It would be a good chance to review the rest of the lines in that file, some others may be worth removing as well.

Related to #4356

@HEndo12345
Copy link
Contributor

HEndo12345 commented Feb 26, 2020

Hi, may I work on this? Its my first time contributing to a project.

@PhanatosZou
Copy link

PhanatosZou commented Feb 27, 2020

Hi, I'm new here. If the issue is not assigned, I'd like to help out!

@Gallaecio
Copy link
Member Author

Gallaecio commented Feb 27, 2020

@PhanatosZou sorry, @HEndo12345 beat you to it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants