-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Remove defer.returnValue calls #4443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello, can I work on this? It's a good 1st issue for me. Thank you! |
@eyelesbarrow sure |
@wRAR Can multiple people work on this issue? |
@devmodi154 that would be duplicated work, wouldn't it? |
Oh Yeah! So sorry |
@wRAR can i work on this? and i just need to replace returnValue with return? |
@yusofsf there is already a work-in-progress pull request about this, you can see it linked above your comment. It's also more complicated than replacing returnValue with return. |
https://twisted.readthedocs.io/en/latest/core/howto/defer-intro.html#inline-callbacks-using-yield says "On Python 3, instead of writing returnValue(json.loads(responseBody)) you can instead write return json.loads(responseBody). This can be a significant readability advantage, but unfortunately if you need compatibility with Python 2, this isn’t an option.".
The text was updated successfully, but these errors were encountered: