Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove defer.returnValue calls #4443

Closed
wRAR opened this issue Mar 18, 2020 · 7 comments · Fixed by #4489
Closed

Remove defer.returnValue calls #4443

wRAR opened this issue Mar 18, 2020 · 7 comments · Fixed by #4489
Labels

Comments

@wRAR
Copy link
Contributor

@wRAR wRAR commented Mar 18, 2020

https://twisted.readthedocs.io/en/latest/core/howto/defer-intro.html#inline-callbacks-using-yield says "On Python 3, instead of writing returnValue(json.loads(responseBody)) you can instead write return json.loads(responseBody). This can be a significant readability advantage, but unfortunately if you need compatibility with Python 2, this isn’t an option.".

@eyelesbarrow
Copy link

@eyelesbarrow eyelesbarrow commented Mar 19, 2020

Hello, can I work on this? It's a good 1st issue for me. Thank you!

@wRAR
Copy link
Contributor Author

@wRAR wRAR commented Mar 19, 2020

@eyelesbarrow sure

@devmodi154
Copy link

@devmodi154 devmodi154 commented Mar 19, 2020

@wRAR Can multiple people work on this issue?

@wRAR
Copy link
Contributor Author

@wRAR wRAR commented Mar 19, 2020

@devmodi154 that would be duplicated work, wouldn't it?

@devmodi154
Copy link

@devmodi154 devmodi154 commented Mar 19, 2020

Oh Yeah! So sorry

@yusofsf
Copy link

@yusofsf yusofsf commented Mar 31, 2020

@wRAR can i work on this? and i just need to replace returnValue with return?

@wRAR
Copy link
Contributor Author

@wRAR wRAR commented Mar 31, 2020

@yusofsf there is already a work-in-progress pull request about this, you can see it linked above your comment. It's also more complicated than replacing returnValue with return.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants