Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase code sharing between the crawl and runspider commands #4548

Closed
Gallaecio opened this issue May 7, 2020 · 2 comments · Fixed by #4552
Closed

Increase code sharing between the crawl and runspider commands #4548

Gallaecio opened this issue May 7, 2020 · 2 comments · Fixed by #4552
Labels
cleanup good first issue

Comments

@Gallaecio
Copy link
Member

Their add_options and process_options methods are identical. They could be moved into a shared, parent class.
@jay24rajput
Copy link
Contributor

Hello, I would like to work on this issue. Is it up for grabs?

@Gallaecio
Copy link
Member Author

@jay24rajput All yours!

@jay24rajput jay24rajput mentioned this issue May 7, 2020
Merged
@wRAR wRAR closed this as completed in #4552 Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Code sharing between crawl and runspider command jay24rajput/scrapy
2 participants
@Gallaecio @jay24rajput