Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spiderloader: Add tests for duplicate locations #4549

Closed
elacuesta opened this issue May 7, 2020 · 5 comments · Fixed by #4560
Closed

Spiderloader: Add tests for duplicate locations #4549

elacuesta opened this issue May 7, 2020 · 5 comments · Fixed by #4560

Comments

@elacuesta
Copy link
Member

elacuesta commented May 7, 2020

See https://github.com/scrapy/scrapy/pull/4543/files/4c12a234ae65d49678a9840708ff5e7b9d6dcecc#diff-04eeb72b0ac2a03d00f2b1dcc3268ebc

@MichaelArnoldOwens
Copy link

MichaelArnoldOwens commented May 9, 2020

I saw that this was mentioned in #4543 is this issue still open?

@elacuesta
Copy link
Member Author

elacuesta commented May 9, 2020

It is indeed, this was created as a reminder because it fell out of the scope of #4543, which was limited to stylistic changes.

@adityaa30
Copy link
Contributor

adityaa30 commented May 9, 2020

@elacuesta I think tests are already present here?

@Gallaecio
Copy link
Member

Gallaecio commented May 9, 2020

In that case we need to find out why they did not fail with 4c12a23

@adityaa30
Copy link
Contributor

adityaa30 commented May 9, 2020

@Gallaecio Probably because in 4c12a23 there will be a warning raised which the current test actually expects. Although if we assert count of duplicates locations more than one then the test will fail in 4c12a23. Shall I send a PR to update the tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants