Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downloadable documentation is missing for versions 2.0 and 2.1 on readthedocs.org #4578

Closed
IlnarSelimcan opened this issue May 14, 2020 · 4 comments · Fixed by #4585
Closed

Downloadable documentation is missing for versions 2.0 and 2.1 on readthedocs.org #4578

IlnarSelimcan opened this issue May 14, 2020 · 4 comments · Fixed by #4585
Labels
bug docs

Comments

@IlnarSelimcan
Copy link

IlnarSelimcan commented May 14, 2020

For some reason downloadable documentation on https://readthedocs.org/projects/scrapy/downloads/ is available only up to version 1.8.

That's a minor issue, but I think that I'm not the only one who prefers to read technical papers in the pdf format (to be able to take notes).
@nsirletti
Copy link
Contributor

nsirletti commented May 16, 2020

Looks like a .readthdocs.yml config was created for 2.0.0 but we didn't specify downloadable formats as specified in readthedocs.org's doc.

Shall I make a PR ? If so to which branch ?

@Gallaecio
Copy link
Member

Gallaecio commented May 18, 2020

Shall I make a PR ? If so to which branch ?

That would be great. Feel free to create it for master, we can later backport it.

@nsirletti nsirletti mentioned this issue May 19, 2020
Merged
@Gallaecio
Copy link
Member

Gallaecio commented May 19, 2020

Backported to 2.0 and 2.1.

@IlnarSelimcan
Copy link
Author

IlnarSelimcan commented May 19, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make doc downloadable on ReadTheDocs.org nsirletti/scrapy
3 participants
@Gallaecio @IlnarSelimcan @nsirletti