Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for FEEDS.uri_params and FEED_URI_PARAMS #4671

Closed
alex-ber opened this issue Jul 9, 2020 · 1 comment · Fixed by #4724
Closed

Add docs for FEEDS.uri_params and FEED_URI_PARAMS #4671

alex-ber opened this issue Jul 9, 2020 · 1 comment · Fixed by #4724

Comments

@alex-ber
Copy link

alex-ber commented Jul 9, 2020

In https://docs.scrapy.org/en/latest/topics/feed-exports.html#feeds

There is missing entry

uri_params: falls back to FEED_URI_PARAMS

Also FEED_URI_PARAMS setting description is missing (see #4670)

Here

format: the serialization format to be used for the feed. See Serialization formats for possible values. Mandatory, no fallback setting

encoding: falls back to FEED_EXPORT_ENCODING

fields: falls back to FEED_EXPORT_FIELDS

indent: falls back to FEED_EXPORT_INDENT

store_empty: falls back to FEED_STORE_EMPTY
@elacuesta
Copy link
Member

elacuesta commented Jul 9, 2020

Hi @alex-ber, thanks for the report. We were aware of the problem but were not actively tracking it, so thanks for opening this issue.
As I said in the linked comment, I think it might be good to revisit #3873 before tackling this, but it might not be necessary.
One thing I will do though is close #4670, we can keep track of both things here.
Thanks again.

@elacuesta elacuesta changed the title Documentaion of uri_params in feed-exports is missing Add docs for FEEDS.uri_params and FEED_URI_PARAMS Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants