Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
I can't find any reference to scrapy.utils.python.WeakKeyCache (except in tests) and I think that it should be deprecated.
Keeping non-used and non-documented code makes the codebase harder to maintain.
As it's tested we could keep it, but I don't think it's a good idea.
The text was updated successfully, but these errors were encountered:
Looks like its (last) usage was removed in 332bf3b
Sorry, something went wrong.
I can clean this up. Is it up for grabs? Can someone assign this to me, please?
This would be my first open-source contribution :)
@kshitijcode No need to ask first, feel free to go ahead! 🙂
Code cleanup scrapy.utils.python.WeakKeyCache scrapy#4684
I have raised the PR with the necessary changes: #4701
But I am not sure what is failing the tests.
Tests pass successfully locally after adding -W ignore::pytest.PytestDeprecationWarning. to tox.ini
I am not really sure whats breaking in Azure Pipelines.
@kshitijcode the test failure is unrelated to your changes, I've created #4702 to track it
Code cleanup scrapy.utils.python.WeakKeyCache scrapy#4684 and fixing …
Merge pull request #4701 from kshitijcode/weakkeycache-cleanup-4684
Code cleanup scrapy.utils.python.WeakKeyCache #4684
Successfully merging a pull request may close this issue.