Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort the list of Request.meta keys alphabetically #5061

Closed
Gallaecio opened this issue Mar 22, 2021 · 1 comment · Fixed by #5065
Closed

Sort the list of Request.meta keys alphabetically #5061

Gallaecio opened this issue Mar 22, 2021 · 1 comment · Fixed by #5065
Labels
docs enhancement good first issue

Comments

@Gallaecio
Copy link
Member

The list is rather long, and getting longer with time, so I think it would be best to keep it sorted alphabetically, to make lookup easier.
@kmike
Copy link
Member

kmike commented Mar 22, 2021

The only (super-minor) issue I can see is that it'd remove

  • dont_merge_cookies
  • cookiejar

grouping; it may worth checking if we should add some text to some docs to make them more easily discoverable.

pratik1500 added a commit to pratik1500/scrapy that referenced this issue Mar 23, 2021
@pratik1500
Sort the list of Request.meta alphabetically scrapy#5061
ca3bbc9
@pratik1500 pratik1500 mentioned this issue Mar 23, 2021
Merged
pratik1500 added a commit to pratik1500/scrapy that referenced this issue Mar 23, 2021
@pratik1500
Sort the list of Request.meta alphabetically scrapy#5061
8c194e5
pratik1500 added a commit to pratik1500/scrapy that referenced this issue Mar 23, 2021
@pratik1500
Sort the list of Request.meta alphabetically scrapy#5061
c760657
pratik1500 added a commit to pratik1500/scrapy that referenced this issue Mar 23, 2021
@pratik1500
Sort the list of Request.meta alphabetically scrapy#5061
b47e224
pratik1500 added a commit to pratik1500/scrapy that referenced this issue Mar 23, 2021
@pratik1500
Sort the list of Request.meta alphabetically scrapy#5061
e6157fc
kmike pushed a commit that referenced this issue Mar 23, 2021
@pratik1500
Sort the list of Request.meta alphabetically #5061 (#5065)
f0e1a33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sort the list of Request.meta alphabetically #5061 pratik1500/scrapy
2 participants
@kmike @Gallaecio