Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building the documentation with make in systems without /bin/bash #5080

Closed
Gallaecio opened this issue Apr 5, 2021 · 2 comments · Fixed by #5082
Closed

Allow building the documentation with make in systems without /bin/bash #5080

Gallaecio opened this issue Apr 5, 2021 · 2 comments · Fixed by #5082

Comments

@Gallaecio
Copy link
Member

595146e#r48800250

I’m guessing the current code exists in line with https://stackoverflow.com/a/589300/939364, in order to force Bash to be used (instead of something like sh).

If there is a way to set SHELL to Bash so that it finds the right path to Bash regardless of the system, that would be great. Otherwise, maybe we can check if there is any Bash-specific code in this Makefile. If all commands work as intended with sh, for example, maybe we can just remove this line as suggested.

@apalala
Copy link

apalala commented Apr 8, 2021

How about this?

BASH=`which bash`

@Gallaecio
Copy link
Member Author

The approach in #5082 sounds good, in modern scripting #!/usr/bin/env bash is often the recommended line to put at the beginning of a Bash script. I haven’t approved it yet because I want to test it manually first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants