Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileFeedStoragePreFeedOptionsTest fails if /tmp/foobar already exists with different ownership #5157

Closed
risicle opened this issue May 23, 2021 · 0 comments · Fixed by #5198
Closed

Comments

@risicle
Copy link

risicle commented May 23, 2021

Quick one - if, for instance, you're running the the scrapy test suite in some sort of CI setup where builds get performed by random different dedicated "build users", you'll end up in a situation where /tmp/foobar already exists, owned by a different user. At which point FileFeedStoragePreFeedOptionsTest will fail:

E       PermissionError: [Errno 13] Permission denied: '/tmp/foobar'

Fairly trivial to fix - you could put a random suffix on the filename.. better, generate a directory to contain it using tempfile.mkdtemp.. many options.

Full build failure log: https://nix-cache.s3.amazonaws.com/log/5fdywg4w7s6cyf224j42yn9619kw5gw1-python3.8-Scrapy-2.4.1.drv

Versions

Scrapy 2.4.1, python 3.8, macos 10.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants