Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: unobvious StatsMailer extension description #5199

Closed
AvachaBay opened this issue Jul 4, 2021 · 2 comments · Fixed by #5217
Closed

Docs: unobvious StatsMailer extension description #5199

AvachaBay opened this issue Jul 4, 2021 · 2 comments · Fixed by #5217
Labels
docs enhancement good first issue

Comments

@AvachaBay
Copy link

Description

Hello!

Please put reference to MailSender in StatsMailer extension
because it is not obvious that the extension needs any configuration
@aaron-tan
Copy link
Contributor

Hi, I'm new to contributing to open source projects and this seems like something I could start out with. Could I work on this?

@wRAR
Copy link
Member

wRAR commented Jul 18, 2021

@aaron-tan sure, you don't need a permission for this.

@aaron-tan aaron-tan mentioned this issue Jul 24, 2021
Merged
@wRAR wRAR closed this as completed in #5217 Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reference MailSender in StatsMailer aaron-tan/scrapy
3 participants
@wRAR @AvachaBay @aaron-tan