Skip to content

Test failures on 3.10 #5212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wRAR opened this issue Jul 20, 2021 · 0 comments · Fixed by #5221
Closed

Test failures on 3.10 #5212

wRAR opened this issue Jul 20, 2021 · 0 comments · Fixed by #5221
Labels
bug CI

Comments

@wRAR
Copy link
Member

wRAR commented Jul 20, 2021

I ran the test suite on 3.10b4, we have three test failures. One is easily fixed by replacing collections with collections.abc in scrapy/utils/signal.py (collections.Sequence no longer exists in 3.10 and is apparently deprecated before that), other two are less trivial: https://github.com/wRAR/scrapy/runs/3111526014?check_suite_focus=true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing tests for upcoming 3.10. wRAR/scrapy
1 participant
@wRAR