Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from optparse to argparse #5366

Closed
BurnzZ opened this issue Jan 14, 2022 · 10 comments · Fixed by #5374
Closed

Move from optparse to argparse #5366

BurnzZ opened this issue Jan 14, 2022 · 10 comments · Fixed by #5374

Comments

@BurnzZ
Copy link
Member

BurnzZ commented Jan 14, 2022

The optparse module has been deprecated since 3.2 in lieu of argparse.

At the time of this writing, we only have 3 modules that use it directly:

I'm filing this ticket to keep track of this task. In addition there were several attempts on this in the past that hasn't pushed through:

@kawishqayyum
Copy link

Can I work on this, please?

@LusiferAjay
Copy link

Hi @Gallaecio I am new in the open source world
can I work on this? if this is not available let me know if anything else is there from which I can start my Journey

@wRAR
Copy link
Member

wRAR commented Jan 15, 2022

@kawishqayyum @LusiferAjay you don't need a permission to work on any issue

@Jerry-Mah
Copy link

Hello, I would like to work on this issue. How should I go about solving this issue?

@wRAR wRAR changed the title deprecate optparse usage Move from optparse to argparse Jan 21, 2022
alexpdev added a commit to alexpdev/scrapy that referenced this issue Jan 22, 2022
@alexpdev
Copy link
Contributor

I submitted #5374 which addresses this Issue.

@bryangators
Copy link

Hello, I plan to work on this issue. I see a pr is pending but I would like to take a shot at it as well. I am participating in this for a course. Thanks.

@bryangators
Copy link

How do I build the scrapy repo locally with the source code. I tried installing locally with 'pip install -e scrapy/' but it does not run. I am able to get it to run when downloading from pip. I guess my question is how do I get a local build where I can modify and view changes from my local repo?

@wRAR
Copy link
Member

wRAR commented Jan 28, 2022

pip install -e scrapy in a venv should work.

@bryangators
Copy link

I must of had a bad setup in virtualenv. I switched to conda and it works now. Thanks!

@bryangators
Copy link

I created a pull request #5382 to solve this. It is very similar to #5374 above but this commit solves the issue in scrapy/commands/view.py where "--header" option is to be removed. Still need an admin to approve workflows for codecov to run coverage tests. This is my first commit to open source and look forward to hearing any feedback. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants