-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests broken with Twisted 22.1.0 #5400
Comments
The direct failures are caused by removal of I'm going to run tests with these class definitions copied from the old Twisted code. |
The tests worked, so Scrapy itself is unlikely to be impacted and the tests can be fixed by copying that code. Still, I wonder if there is something better in Twisted that would allow us to have the same tests without relying on this code.
So maybe the easiest way is still just copying the resource classes and not doing anything else. |
ImportError: cannot import name 'PayloadResource' from 'twisted.web.test.test_webclient'
ImportError: cannot import name 'ForeverTakingResource' from 'twisted.web.test.test_webclient'
The text was updated successfully, but these errors were encountered: