Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change external link (for robots.txt parser comparison) in docs to a more lasting page #5414

Closed
anubhavp28 opened this issue Feb 13, 2022 · 2 comments · Fixed by #5415
Closed

Comments

@anubhavp28
Copy link
Contributor

Scrapy documentation (at the end of this section) links to a blog that contains performance numbers for different robots.txt parser backends. It would be better to change the link to point to this issue as it is more lasting. Currently, we are linking to a personal blog website which might disappear if the blog owner decides to change the hosting or blog name.

@anubhavp28 anubhavp28 changed the title Change robots.txt parser comparison link in Scrapy documentation Change robots.txt parser comparison link in documentation Feb 13, 2022
@anubhavp28 anubhavp28 changed the title Change robots.txt parser comparison link in documentation Change external link (for robots.txt parser comparison) in docs to a more lasting page Feb 13, 2022
@eddybruv
Copy link

@anubhavp28 please can you review my pull request and tell me if there's any problem with it.

@anubhavp28
Copy link
Contributor Author

Looks good to me. Scrapy maintainers will review and merge your PR when they will get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants