Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImportError: cannot import name 'soft_unicode' from 'markupsafe' #5425

Closed
Gallaecio opened this issue Feb 22, 2022 · 3 comments · Fixed by #5427
Closed

ImportError: cannot import name 'soft_unicode' from 'markupsafe' #5425

Gallaecio opened this issue Feb 22, 2022 · 3 comments · Fixed by #5427
Labels

Comments

@Gallaecio
Copy link
Member

Looking at the CI jobs of #4267, pallets/markupsafe#282 is hitting us in some scenarios.

@wRAR
Copy link
Member

wRAR commented Feb 22, 2022

Right, I've restarted tests for master some time ago to check that and forgot to check the results.

https://github.com/scrapy/scrapy/actions/runs/1855091848
https://github.com/scrapy/scrapy/actions/runs/1855091860

@wRAR
Copy link
Member

wRAR commented Feb 22, 2022

So I guess this is because old mitmproxy, which we use for older Python versions and in other cases, requires old Flask which is affected.

@wRAR
Copy link
Member

wRAR commented Feb 23, 2022

I think it should be enough to pin markupsafe in the same cases that pin mitmproxy (also in conda).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants