Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"scrapy crawl myspider -o data.csv" should write csv #546

Closed
kmike opened this issue Jan 18, 2014 · 7 comments
Closed

"scrapy crawl myspider -o data.csv" should write csv #546

kmike opened this issue Jan 18, 2014 · 7 comments

Comments

@kmike
Copy link
Member

@kmike kmike commented Jan 18, 2014

What do you think about removing a need to write this?

$ scrapy crawl myspider -t csv -o data.csv

Of course, other file extensions could be also supported.

@dangra
Copy link
Member

@dangra dangra commented Jan 20, 2014

+1

2 similar comments
@nramirezuy
Copy link
Contributor

@nramirezuy nramirezuy commented Jan 20, 2014

+1

@pablohoffman
Copy link
Member

@pablohoffman pablohoffman commented Jan 20, 2014

+1

denysbutenko added a commit to denysbutenko/scrapy that referenced this issue Apr 6, 2014
denysbutenko added a commit to denysbutenko/scrapy that referenced this issue Apr 6, 2014
* master:
  Added more verbose error message for unrecognized output format. PEP8.
  Add import os for crawl.
  Fix default value.
  Added back `-t` option. If `--output-format` not defined parse from extension `--output`
  Resolved issue scrapy#546. Output format parsing from filename extension.
dangra added a commit that referenced this issue Apr 14, 2014
[MRG] Resolved issue #546. Output format parsing from filename extension.
@kmike
Copy link
Member Author

@kmike kmike commented Apr 24, 2014

#659 almost resolved this, but there are 2 things that should be improved:

  1. docs should be updated;
  2. the extension for jsonlines format is "jsonlines". I haven't realized this when reviewing the PR. It also means the change was backwards-incompatible because crawl myspider -o res.jl is broken now.
@dangra
Copy link
Member

@dangra dangra commented Jun 25, 2014

#659 almost resolved this, but there are 2 things that should be improved:

  1. docs should be updated;
  2. the extension for jsonlines format is "jsonlines". I haven't realized this when reviewing the PR. It also means the change was backwards-incompatible because crawl myspider -o res.jl is broken now.

take a look to #760.

@nramirezuy
Copy link
Contributor

@nramirezuy nramirezuy commented Jul 23, 2014

#659 and #760 already merged, can we close this? @dangra @kmike

@kmike
Copy link
Member Author

@kmike kmike commented Jul 23, 2014

@nramirezuy yes, a good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.