Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make asyncio reactor a default #5590

Closed
kmike opened this issue Aug 5, 2022 · 4 comments · Fixed by #5679
Closed

Make asyncio reactor a default #5590

kmike opened this issue Aug 5, 2022 · 4 comments · Fixed by #5679
Assignees
Milestone

Comments

@kmike
Copy link
Member

kmike commented Aug 5, 2022

Should we make 'twisted.internet.asyncioreactor.AsyncioSelectorReactor' a default? If so, should it be default in Scrapy 2.7, or is it too soon? We can start with making it default in the project template; it looks safe enough for Scrapy 2.7, or is it?

The reactor was introduced in Scrapy 2.0; I don't recall any particular issues reported about it. It'd be good to have it as a default eventually, because there are more an more Scrapy plugins which rely on asyncio libraries.

@kmike kmike added the discuss label Aug 5, 2022
@kmike kmike added this to the 2.7 milestone Aug 5, 2022
@pablohoffman
Copy link
Member

Are there any big users/projects using the asyncio reactor @kmike?

@kmike
Copy link
Member Author

kmike commented Aug 5, 2022

@pablohoffman packages like

require asyncio reactor; any Scrapy project which uses one of these extensions needs to switch to ascynio reactor.

@elacuesta
Copy link
Member

Related: #5103

@pablohoffman
Copy link
Member

Thanks. As far as I'm concerned, it makes sense, and changing the default project template is a good way to start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants