Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the return type of callbacks #5602

Closed
wRAR opened this issue Aug 18, 2022 · 2 comments · Fixed by #5608
Closed

Clarify the return type of callbacks #5602

wRAR opened this issue Aug 18, 2022 · 2 comments · Fixed by #5608

Comments

@wRAR
Copy link
Member

wRAR commented Aug 18, 2022

https://docs.scrapy.org/en/latest/topics/spiders.html#scrapy.Spider.parse says "This method, as well as any other Request callback, must return an iterable of Request and/or item objects.", but it can also return a single Request/an item object. It's possible there are other places with a similar omission.

@DerMoehre
Copy link

Hi,
I would love to contribute to this project, but as I am just learning Python, I dont really know where to start :)
Could someone give me a bit of guidance?

@Gallaecio
Copy link
Member

This specific issue is kind of taken, close to be merged.

If you find a ticket you are willing to work on, feel free to ask specific questions about it. However, I must say Scrapy may not be the best project to get started contributing as you learn Python: the code base is complex (async programming can be complex on its own, and Scrapy uses Twisted which is not the easiest solution to learn on that front), and our “good first issue” tickets are taken rather quickly, so there are rarely any not being already worked on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants