Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Twisted 22.8.0 #5621

Closed
wRAR opened this issue Sep 8, 2022 · 5 comments · Fixed by #5632
Closed

Support for Twisted 22.8.0 #5621

wRAR opened this issue Sep 8, 2022 · 5 comments · Fixed by #5632

Comments

@wRAR
Copy link
Member

wRAR commented Sep 8, 2022

Twisted 22.8.0 was released recently, and it says:

Twisted now works with Cryptography versions 37 and above, and as a result, its minimum TLS protocol version has been upgraded to TLSv1.2.

Consequently, tests on some envs, including 3.8, now fail because they install older cryptography.

@wRAR
Copy link
Member Author

wRAR commented Sep 8, 2022

Also, I haven't yet checked but it may mean that Scrapy with this Twisted version will no longer work with some servers (it also needs to be checked if it's a hard restriction or the TLS version can be lowered with settings)

@wRAR
Copy link
Member Author

wRAR commented Sep 15, 2022

We've found an interesting data point regarding the "support older TLS" part: https://chromestatus.com/feature/5759116003770368 says older TLS is no longer supported in Chromium and I can confirm it using https://badssl.com/ (https://tls-v1-1.badssl.com:1011/). While we usually strive to support as many real-world servers as possible, it should be a lower priority to support servers that are already dropped from a major browser.

@Gallaecio
Copy link
Member

Gallaecio commented Sep 15, 2022

Same for Firefox. “This website might not support the TLS 1.2 protocol, which is the minimum version supported by Firefox.” Let’s burn TLS 1.1 and earlier with fire 🔥 .

@wRAR
Copy link
Member Author

wRAR commented Oct 5, 2022

What is left to do here?

@Gallaecio
Copy link
Member

Nothing else I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants