Skip to content

Add twine check to CI #5655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kmike opened this issue Oct 2, 2022 · 2 comments · Fixed by #5656
Closed

Add twine check to CI #5655

kmike opened this issue Oct 2, 2022 · 2 comments · Fixed by #5656

Comments

@kmike
Copy link
Member

kmike commented Oct 2, 2022

It'd be nice to do https://twine.readthedocs.io/en/stable/#twine-check on CI, to ensure our changes don't break pypi rendering.

@armujahid
Copy link
Contributor

armujahid commented Oct 2, 2022

How to create dist for twine check? I have tried python setup.py build and python setup.py sdist. 2nd one is creating dist with Scrapy-2.6.2.tar.gz

Running twine check dist throws this error

Checking dist: ERROR    InvalidDistribution: Unknown distribution format: 'dist'                                                                                                                      

Looks like I am doing something wrong
Related: #5648

Update #1:
I created dist using python setup.py sdist bdist_wheel but I am getting same error with twine check. dist directory has Scrapy-2.6.2-py2.py3-none-any.whl and Scrapy-2.6.2.tar.gz

@armujahid
Copy link
Contributor

armujahid commented Oct 2, 2022

I think this is the correct way to run twine check. Correct me If I am wrong.

rm -rf dist
python setup.py sdist bdist_wheel
twine check dist/*

Update: Correct steps to create distribution are also mentioned here in publish workflow
Now I think I just need to add a new check in checks.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants