Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove settings._DictProxy #5729

Closed
wRAR opened this issue Nov 23, 2022 · 1 comment · Fixed by #5730
Closed

Remove settings._DictProxy #5729

wRAR opened this issue Nov 23, 2022 · 1 comment · Fixed by #5730
Labels
cleanup good first issue

Comments

@wRAR
Copy link
Member

wRAR commented Nov 23, 2022

As discussed in #5452, scrapy.settings._DictProxy isn't needed anymore so we can remove it (looks like we decided to do that without deprecating it).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup settings._DictProxy and scrapy.telnet burneyh/scrapy
2 participants
@wRAR @oldsiks