Skip to content

AsyncioTest failures #5765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wRAR opened this issue Dec 19, 2022 · 1 comment · Fixed by #5782
Closed

AsyncioTest failures #5765

wRAR opened this issue Dec 19, 2022 · 1 comment · Fixed by #5782

Comments

@wRAR
Copy link
Member

wRAR commented Dec 19, 2022

There are two new failing tests (AsyncioTest.test_install_asyncio_reactor and AsyncioTest.test_is_asyncio_reactor_installed) on 3.10 and 3.11, and it looks like they started failing after updating to 3.10.9 and 3.11.1 (it may be a coincidence though). I see an asyncio-related change in those versions: "asyncio.get_event_loop() now only emits a deprecation warning when a new event loop was created implicitly. It no longer emits a deprecation warning if the current event loop was set." and it looks like it's the cause for the test_install_asyncio_reactor failure as that checks for a warning and maybe there is some new warning. But the second test is about installing the reactor and checking its type and the failure looks like the asyncio reactor is installed when it shouldn't.

@wRAR
Copy link
Member Author

wRAR commented Dec 20, 2022

Disabling test_install_asyncio_reactor makes test_is_asyncio_reactor_installed pass; I suspect that the former now installs the reactor when previously it didn't (initially this test had a comment "does nothing" but I don't remember why did this call do nothing), this needs future investigation. It may actually just depend on the test run order, maybe it actually broke some time ago.

As for test_install_asyncio_reactor, the new warning is "DeprecationWarning('There is no current event loop')". Which is the same as we got in #5685 and we had a fix for it. Maybe we need a different fix for the current Python version (I wonder if we need to test older point releases, likely we don't).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant