Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pylint from pre-commit #5810

Closed
Gallaecio opened this issue Jan 27, 2023 · 1 comment · Fixed by #5806
Closed

Remove pylint from pre-commit #5810

Gallaecio opened this issue Jan 27, 2023 · 1 comment · Fixed by #5806

Comments

@Gallaecio
Copy link
Member

pylint can take quite a while to run, so I think it may be best not to run it as part of pre-commit, and only run it with tox or on the CI.

@jxlil
Copy link
Contributor

jxlil commented Jan 28, 2023

Just to give context on this. I did a test with and without pylint in .pre-commit-config.yaml:

With pylint it takes 45s to create the commit.

$ time git commit -m "test" -a
bandit...................................................................Passed
flake8...................................................................Passed
pylint...................................................................Passed
black....................................................................Passed
[detached HEAD df6885fb] test
 1 file changed, 1 insertion(+), 1 deletion(-)
git commit -m "test" -a  45.05s user 1.78s system 98% cpu 47.371 total

Without pylint it takes 0.74s to create the commit.

$ time git commit -m "test" -a
bandit...................................................................Passed
flake8...................................................................Passed
black....................................................................Passed
[detached HEAD a8107f27] test
 1 file changed, 1 insertion(+), 1 deletion(-)
git commit -m "test" -a  0.74s user 0.29s system 86% cpu 1.187 total

@Gallaecio Gallaecio mentioned this issue Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants