Skip to content

get_func_args does not fully work in CPython #5872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jelgun opened this issue Mar 26, 2023 · 2 comments · Fixed by #5885
Closed

get_func_args does not fully work in CPython #5872

jelgun opened this issue Mar 26, 2023 · 2 comments · Fixed by #5885
Assignees
@serhii73
Labels
bug

Comments

@jelgun
Copy link

jelgun commented Mar 26, 2023 •
edited by Gallaecio
Loading

As shown in tests, get_func_args does not work in CPython with inputs like str.split, "".join or itemgetter(2).
@jelgun jelgun changed the title return actual argument names in test_get_func_args.py return actual argument names in test_utils_python.py Mar 26, 2023
@jelgun jelgun mentioned this issue Mar 26, 2023
Closed
@Gallaecio Gallaecio changed the title return actual argument names in test_utils_python.py get_func_args does not fully work in CPython Mar 27, 2023
@Gallaecio Gallaecio added the bug label Mar 27, 2023
@wRAR
Copy link
Member

wRAR commented Mar 28, 2023

If/when somebody works on this, please check if get_func_args can just be replaced by inspect.signature (which "Accepts a wide range of Python callables, from plain functions and classes to functools.partial() objects." but wasn't available when get_func_args was written).

@serhii73
Copy link
Collaborator

I'm on it.

@serhii73 serhii73 mentioned this issue Apr 7, 2023
Merged
@serhii73 serhii73 mentioned this issue Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serhii73 serhii73

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace get_func_args serhii73/scrapy
4 participants
@wRAR @Gallaecio @jelgun @serhii73