Skip to content

NotConfigured logging breaks when the component is added by class object #5992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wRAR opened this issue Aug 1, 2023 · 0 comments · Fixed by #5950
Closed

NotConfigured logging breaks when the component is added by class object #5992

wRAR opened this issue Aug 1, 2023 · 0 comments · Fixed by #5950
Labels
bug good first issue

Comments

@wRAR
Copy link
Member

wRAR commented Aug 1, 2023 •
edited
Loading

As the log message for components that raise NotConfigured with a message assumes clsname is an import path string, it raises an AttributeError when it's a class instance.

scrapy/scrapy/middleware.py

Line 49 in bddbbc5

clsname = clspath.split(".")[-1]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add-ons wRAR/scrapy
1 participant
@wRAR