Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Alll SEPs to RST #629

Closed
aspidites opened this issue Mar 6, 2014 · 10 comments
Closed

Convert Alll SEPs to RST #629

aspidites opened this issue Mar 6, 2014 · 10 comments

Comments

@aspidites
Copy link
Contributor

@aspidites aspidites commented Mar 6, 2014

It would be nice to convert the older SEPs to rst format from their original trac versions. By doing so:

  • documentation willl be more consistent
  • github will automatically render them to html when browsed
  • it would be possible to include them as an appendix to the official documentation

I would be willing (and already have started) to do this myself.

@pablohoffman
Copy link
Member

@pablohoffman pablohoffman commented Mar 7, 2014

Great initiative @aspidites !

@aspidites
Copy link
Contributor Author

@aspidites aspidites commented Mar 7, 2014

Thanks. I'll finish the remaining SEPs this afternoon. For now, I need sleep :-).

pablohoffman added a commit that referenced this issue Mar 7, 2014
- removed trac file for #629
@pablohoffman
Copy link
Member

@pablohoffman pablohoffman commented Mar 7, 2014

Thanks @aspidites, so far only SEP-001 it's merged with 2 pull requests. For cleanness purposes, let's make sure each PR adds the RST and removes the trac file in the same commit. You can update existing PRs (with git push -f) or create new ones. I'm also happy with a larger PR with many SEPs migrated at once.

@aspidites
Copy link
Contributor Author

@aspidites aspidites commented Mar 7, 2014

Already a step ahead of you. You'll see the existing PRs have all been
updated already :-) As for combined PR, I'll write this last one separately
then commit the final ones as one large PR.
On Mar 7, 2014 9:43 AM, "Pablo Hoffman" notifications@github.com wrote:

Thanks @aspidites https://github.com/aspidites, so far only SEP-001
it's merged with 2 pull requests. For cleanness purposes, let's make sure
each PR adds the RST and removes the trac file in the same commit. You can
update existing PRs (with git push -f) or create new ones. I'm also happy
with a larger PR with many SEPs migrated at once.

Reply to this email directly or view it on GitHubhttps://github.com//issues/629#issuecomment-37029738
.

@pablohoffman
Copy link
Member

@pablohoffman pablohoffman commented Mar 7, 2014

nice! :)

pablohoffman added a commit that referenced this issue Mar 7, 2014
converted sep 3 for #629
pablohoffman added a commit that referenced this issue Mar 7, 2014
 sep 6 for #629
pablohoffman added a commit that referenced this issue Mar 7, 2014
sep 12 for #629
@pablohoffman
Copy link
Member

@pablohoffman pablohoffman commented Mar 7, 2014

I didn't say my preference was a big PR, just thought it would be more convenient for you, that's all.

pablohoffman added a commit that referenced this issue Mar 7, 2014
- sep 15 for #629
pablohoffman added a commit that referenced this issue Mar 7, 2014
sep 11 for #629
pablohoffman added a commit that referenced this issue Mar 7, 2014
converted sep 7 for #629
pablohoffman added a commit that referenced this issue Mar 7, 2014
sep 10 for #629
@aspidites
Copy link
Contributor Author

@aspidites aspidites commented Mar 7, 2014

@pablohoffman, my mistake. I actually preferred the smaller commits because it allows me to make micro changes without fear of breaking something else, which in turn means things that are ready can get merged sooner than things that are still getting worked on.

That said...I apologize in advance, as I may or may not have forgone sleep in favor of finishing the remaining 7 SEP conversions...

pablohoffman added a commit that referenced this issue Mar 7, 2014
sep 4 for #629
@pablohoffman
Copy link
Member

@pablohoffman pablohoffman commented Mar 7, 2014

Cool, only SEP-014 left?

@aspidites
Copy link
Contributor Author

@aspidites aspidites commented Mar 7, 2014

I guess it might have helped if I opened a pull request way bak when I finished it, huh? Sorry about that

pablohoffman added a commit that referenced this issue Mar 8, 2014
sep 14 for #629
@kmike
Copy link
Member

@kmike kmike commented Mar 10, 2014

Thanks @aspidites!

@kmike kmike closed this Mar 10, 2014
chekunkov added a commit to chekunkov/scrapy that referenced this issue Apr 26, 2014
chekunkov added a commit to chekunkov/scrapy that referenced this issue Apr 26, 2014
chekunkov added a commit to chekunkov/scrapy that referenced this issue Apr 26, 2014
chekunkov added a commit to chekunkov/scrapy that referenced this issue Apr 26, 2014
chekunkov added a commit to chekunkov/scrapy that referenced this issue Apr 26, 2014
chekunkov added a commit to chekunkov/scrapy that referenced this issue Apr 26, 2014
chekunkov added a commit to chekunkov/scrapy that referenced this issue Apr 26, 2014
chekunkov added a commit to chekunkov/scrapy that referenced this issue Apr 26, 2014
chekunkov added a commit to chekunkov/scrapy that referenced this issue Apr 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.