Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PY3: fix has_key and use six.moves.configparser #798

Merged
merged 1 commit into from Jul 14, 2014

Conversation

felixonmars
Copy link
Contributor

Yet another small change for py3k support.

@@ -75,7 +75,7 @@ def test_contains(self):
d = CaselessDict()
d['a'] = 1
assert 'a' in d
assert d.has_key('a')
assert 'a' in d.keys()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a test for CarelessDict(), I suppose writing both "in" and "has_key" before was meant to something like this. Removing this line is also a solution :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I've resubmitted it to remove the line.

@kmike
Copy link
Member

kmike commented Jul 14, 2014

Making changes to bundled 3rd-party libraries is controversial, but as per @dangra's comment (#431 (comment)) it is OK to modify pydispatch. So merging it. Thanks!

kmike added a commit that referenced this pull request Jul 14, 2014
PY3: fix has_key and use six.moves.configparser
@kmike kmike merged commit 2f567f9 into scrapy:master Jul 14, 2014
@dangra
Copy link
Member

dangra commented Jul 14, 2014

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants