[WIP] fix xmliter namespace on selected node #861
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 to iterparse |
|
what's left for this WIP to become MRG? |
|
@pablohoffman Know if we keep this approach or we move to iterparse. |
Merged
This was referenced Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was triggered by scrapy-users
Actually
xmliterpopulates aSelectorwith everything from the position 0 to the tag start, so if we had 100mb before the tag we want to iter it copy those 100mb across all theSelectorobjects. Also it just extract this info for the first tag and embed the rest on that, this can cause info crossing.In this PR I kept the regex stuff even tho I think we should use something like
iterparse.Currently
xmliter_lxmltests are failing due to it has a different API.