Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC reorder topics #1022

Merged
merged 1 commit into from Mar 13, 2015
Merged

DOC reorder topics #1022

merged 1 commit into from Mar 13, 2015

Conversation

@kmike
Copy link
Member

@kmike kmike commented Jan 22, 2015

Users need to scroll http://doc.scrapy.org/en/latest/ each time they want to look up what "response" provides: Request/Response docs are buried in the bottom. In this PR they are moved to "Basic Concepts" section. Other changes:

  • duplicate "topics/commands" link is removed;
  • settings docs are moved to "Basic Concepts";
  • exceptions docs are moved to "Basic Concepts";
  • "signals" and "exporters" docs are moved to "Extending Scrapy";
  • "Reference" section is dropped because it is empty now.
* duplicate "topics/commands" link is removed;
* Request/Response docs are moved to "Basic Concepts";
* settings docs are moved to "Basic Concepts";
* exceptions docs are moved to "Basic Concepts";
* "signals" and "exporters" docs are moved to "Extending Scrapy";
* "Reference" section is dropped because it is empty now.
@pablohoffman
Copy link
Member

@pablohoffman pablohoffman commented Jan 28, 2015

LGTM

@kmike kmike added the docs label Mar 5, 2015
@kmike kmike added this to the Scrapy 1.0 milestone Mar 5, 2015
@curita
Copy link
Member

@curita curita commented Mar 12, 2015

LGTM too, can we merge it?

@kmike
Copy link
Member Author

@kmike kmike commented Mar 13, 2015

Usually we require +1's from two core members, here we have three :)

kmike added a commit that referenced this pull request Mar 13, 2015
DOC reorder topics
@kmike kmike merged commit c1bf836 into master Mar 13, 2015
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@kmike kmike deleted the docs-reorder branch Mar 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants