Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3-ignores.txt supports comments #1044

Merged
merged 2 commits into from Feb 10, 2015
Merged

py3-ignores.txt supports comments #1044

merged 2 commits into from Feb 10, 2015

Conversation

@klangner
Copy link
Contributor

@klangner klangner commented Feb 10, 2015

Hi, I will work on porting Scrapy to Python3. I saw that all problematic tests for python3 are in py3-ignores.txt.
That's great since I know what should be fixed.
While checking few testcases I notice that sometimes fixing will require to modify or even wait for external project (e.g. Twisted). It would be very helpful to be able to annotate those tests so I can leave them for later and focus on next problem. Example:

# Waiting for ticket: http:/github.com/ticket23
tests/test1.py
tests/test2.py

This PR skips lines which starts with '#' from py3-ignores.txt

if fn.strip():
collect_ignore.append(fn.strip())
for line in open('tests/py3-ignores.txt'):
filePath = line.strip()

This comment has been minimized.

@kmike

kmike Feb 10, 2015
Member

could you please rename filePath to file_path or filepath or path?

@kmike
Copy link
Member

@kmike kmike commented Feb 10, 2015

a good idea!

@klangner
Copy link
Contributor Author

@klangner klangner commented Feb 10, 2015

Fixed variable name. I'll stick to python standard next time :-)

@kmike
Copy link
Member

@kmike kmike commented Feb 10, 2015

thanks!

kmike added a commit that referenced this pull request Feb 10, 2015
py3-ignores.txt supports comments
@kmike kmike merged commit 7a745b1 into scrapy:master Feb 10, 2015
1 check failed
1 check failed
continuous-integration/travis-ci The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants