Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import unittest.mock if available. #1066

Merged
merged 1 commit into from Mar 8, 2015
Merged

Import unittest.mock if available. #1066

merged 1 commit into from Mar 8, 2015

Conversation

@berkerpeksag
Copy link
Contributor

@berkerpeksag berkerpeksag commented Mar 6, 2015

mock is in the stdlib since Python 3.3.

@kmike
Copy link
Member

@kmike kmike commented Mar 6, 2015

It makes sense.

There are other occurances of "import mock" in tests, but I guess we can fix the once these tests become enabled. Fixing it now is also an option :)

mock is in the stdlib since Python 3.3.
@berkerpeksag
Copy link
Contributor Author

@berkerpeksag berkerpeksag commented Mar 8, 2015

Good point, thanks! Updated PR.

kmike added a commit that referenced this pull request Mar 8, 2015
Import unittest.mock if available.
@kmike kmike merged commit 671d0a7 into scrapy:master Mar 8, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kmike
Copy link
Member

@kmike kmike commented Mar 8, 2015

Thanks!

@berkerpeksag berkerpeksag deleted the berkerpeksag:mock-import branch Mar 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.